[Xfce-bugs] [Bug 11764] New: [Patch] Broken xflock4 functionality

[b***@xfce.org]

https://bugzilla.xfce.org/show_bug.cgi?id=11764

Bug ID: 11764
Summary: [Patch] Broken xflock4 functionality
Classification: Xfce
Product: Xfce4-session
Version: Unspecified
Hardware: Other
OS: Linux
Status: NEW
Severity: normal
Priority: Medium
Component: General
Assignee: xfce-***@xfce.org
Reporter: ***@hotmail.com
QA Contact: ***@cornell.edu
CC: ***@xfce.org, ***@xfce.org

Created attachment 6131
--> https://bugzilla.xfce.org/attachment.cgi?id=6131&action=edit
Patch to bypass null/blank LockCommand parameter

Commit
http://git.xfce.org/xfce/xfce4-session/commit/?id=e940818853582290af21bf38d73ee26143d500ad
breaks xflock4 functionality if the xfconf LockCommand parameter doesn't exist
or is a blank entry. The

$lock_cmd >/dev/null 2>&1 && exit

will run a blank (empty string) and then exist, never getting to the other
items in the list.

The fix is to prepend to that command a check to see if the variable is blank:

if [ ! -z "$lock_cmd" ]; then
$lock_cmd >/dev/null 2>&1 && exit
fi

Patch attached.

[b***@xfce.org]

https://bugzilla.xfce.org/show_bug.cgi?id=11764

Derk te Bokkel <***@gmail.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@gmail.com

--- Comment #1 from Derk te Bokkel <***@gmail.com> ---
if xfconf is edited to add /general/LockCommand with a valid locker it works ..
Yes the patch is necessary ..

[b***@xfce.org]

https://bugzilla.xfce.org/show_bug.cgi?id=11764

Eric Koegel <***@xfce.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
CC| |***@xfce.org
Resolution|--- |FIXED

--- Comment #2 from Eric Koegel <***@xfce.org> ---
Thanks ToZ! Pushed to master in:
commit 495aac78058cd78e2d34505af204e72a1b4f19ac
Author: Eric Koegel <***@gmail.com>
Date: Sat Mar 28 06:16:10 2015 +0300

Xflock: bypass null/blank LockCommand parameter (Bug #11764)

Commit
http://git.xfce.org/xfce/xfce4-session/commit/?id=e940818853582290af21bf38d73ee26143d500ad
breaks xflock4 functionality if the xfconf LockCommand parameter doesn't
exist or
is a blank entry. The
$lock_cmd >/dev/null 2>&1 && exit
will run a blank (empty string) and then exist, never getting to the other
items
in the list.
Bug report and patch provided by ToZ.
http://git.xfce.org/xfce/xfce4-session/commit/?id=495aac78058cd78e2d34505af204e72a1b4f19ac